diff options
author | John Naylor | 2022-08-27 04:17:36 +0000 |
---|---|---|
committer | John Naylor | 2022-08-27 07:45:18 +0000 |
commit | 4eec2e03c34f9a357d86317b1cd05d80a2ab559d (patch) | |
tree | e65d6159ad61e347fdaf76f4abfa894acc175100 /contrib/jsonb_plperl | |
parent | 52144b6fcd626bb7dbe9fe282329c0174620a34b (diff) |
Be more careful to avoid including system headers after perl.h
Commit 121d2d3d70 included simd.h into pg_wchar.h. This caused a problem
on Windows, since Perl has "#define free" (referring to globals), which
breaks the Windows' header. To fix, move the static inline function
definitions from plperl_helpers.h, into plperl.h, where we already
document the necessary inclusion order. Since those functions were the
only reason for the existence of plperl_helpers.h, remove it.
First reported by Justin Pryzby
Diagnosis and review by Andres Freund, patch by myself per suggestion
from Tom Lane
Discussion: https://www.postgresql.org/message-id/20220826115546.GE2342%40telsasoft.com
Diffstat (limited to 'contrib/jsonb_plperl')
-rw-r--r-- | contrib/jsonb_plperl/jsonb_plperl.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/contrib/jsonb_plperl/jsonb_plperl.c b/contrib/jsonb_plperl/jsonb_plperl.c index 22e90afe1b6..2af1e0c02af 100644 --- a/contrib/jsonb_plperl/jsonb_plperl.c +++ b/contrib/jsonb_plperl/jsonb_plperl.c @@ -4,7 +4,6 @@ #include "fmgr.h" #include "plperl.h" -#include "plperl_helpers.h" #include "utils/fmgrprotos.h" #include "utils/jsonb.h" |