diff options
| author | Peter Eisentraut | 2025-02-20 18:49:27 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2025-02-20 18:49:27 +0000 |
| commit | 3e4d868615408370fe6c2977c32f45a47c372b00 (patch) | |
| tree | ad4dd9cb02d58fb938f2f8e1a8c352bcd9bfe314 /contrib | |
| parent | ab84d0ff806dd791ea9da5f1ca302daf3cf42980 (diff) | |
Remove various unnecessary (char *) casts
Remove a number of (char *) casts that are unnecessary. Or in some
cases, rewrite the code to make the purpose of the cast clearer.
Reviewed-by: Dagfinn Ilmari Mannsåker <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org
Diffstat (limited to 'contrib')
| -rw-r--r-- | contrib/ltree/ltxtquery_io.c | 2 | ||||
| -rw-r--r-- | contrib/pg_trgm/trgm_gist.c | 10 | ||||
| -rw-r--r-- | contrib/postgres_fdw/postgres_fdw.c | 8 |
3 files changed, 10 insertions, 10 deletions
diff --git a/contrib/ltree/ltxtquery_io.c b/contrib/ltree/ltxtquery_io.c index 7b8fba17ff2..ec331607793 100644 --- a/contrib/ltree/ltxtquery_io.c +++ b/contrib/ltree/ltxtquery_io.c @@ -410,7 +410,7 @@ ltxtq_in(PG_FUNCTION_ARGS) { ltxtquery *res; - if ((res = queryin((char *) PG_GETARG_POINTER(0), fcinfo->context)) == NULL) + if ((res = queryin(PG_GETARG_POINTER(0), fcinfo->context)) == NULL) PG_RETURN_NULL(); PG_RETURN_POINTER(res); } diff --git a/contrib/pg_trgm/trgm_gist.c b/contrib/pg_trgm/trgm_gist.c index 14285a919ad..5ba895217b0 100644 --- a/contrib/pg_trgm/trgm_gist.c +++ b/contrib/pg_trgm/trgm_gist.c @@ -106,7 +106,7 @@ makesign(BITVECP sign, TRGM *a, int siglen) SETBIT(sign, SIGLENBIT(siglen)); /* set last unused bit */ for (k = 0; k < len; k++) { - CPTRGM(((char *) &tmp), ptr + k); + CPTRGM(&tmp, ptr + k); HASH(sign, tmp, siglen); } } @@ -186,7 +186,7 @@ cnt_sml_sign_common(TRGM *qtrg, BITVECP sign, int siglen) for (k = 0; k < len; k++) { - CPTRGM(((char *) &tmp), ptr + k); + CPTRGM(&tmp, ptr + k); count += GETBIT(sign, HASHVAL(tmp, siglen)); } @@ -373,7 +373,7 @@ gtrgm_consistent(PG_FUNCTION_ARGS) res = true; for (k = 0; k < len; k++) { - CPTRGM(((char *) &tmp), ptr + k); + CPTRGM(&tmp, ptr + k); if (!GETBIT(sign, HASHVAL(tmp, siglen))) { res = false; @@ -426,7 +426,7 @@ gtrgm_consistent(PG_FUNCTION_ARGS) check = (bool *) palloc(len * sizeof(bool)); for (k = 0; k < len; k++) { - CPTRGM(((char *) &tmp), ptr + k); + CPTRGM(&tmp, ptr + k); check[k] = GETBIT(sign, HASHVAL(tmp, siglen)); } res = trigramsMatchGraph(cache->graph, check); @@ -552,7 +552,7 @@ unionkey(BITVECP sbase, TRGM *add, int siglen) for (i = 0; i < ARRNELEM(add); i++) { - CPTRGM(((char *) &tmp), ptr + i); + CPTRGM(&tmp, ptr + i); HASH(sbase, tmp, siglen); } } diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index b92e2a0fc9f..de43727a2a0 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -5660,13 +5660,13 @@ postgresImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid) attname = PQgetvalue(res, i, 1); typename = PQgetvalue(res, i, 2); attnotnull = PQgetvalue(res, i, 3); - attdefault = PQgetisnull(res, i, 4) ? (char *) NULL : + attdefault = PQgetisnull(res, i, 4) ? NULL : PQgetvalue(res, i, 4); - attgenerated = PQgetisnull(res, i, 5) ? (char *) NULL : + attgenerated = PQgetisnull(res, i, 5) ? NULL : PQgetvalue(res, i, 5); - collname = PQgetisnull(res, i, 6) ? (char *) NULL : + collname = PQgetisnull(res, i, 6) ? NULL : PQgetvalue(res, i, 6); - collnamespace = PQgetisnull(res, i, 7) ? (char *) NULL : + collnamespace = PQgetisnull(res, i, 7) ? NULL : PQgetvalue(res, i, 7); if (first_item) |