diff options
| author | Amit Kapila | 2022-04-07 04:09:25 +0000 |
|---|---|---|
| committer | Amit Kapila | 2022-04-07 04:09:25 +0000 |
| commit | 79b716cfb7a1be2a61ebb4418099db1258f35e30 (patch) | |
| tree | 6d081e1dac75d5aae7f7c3b5af676b1a788bfd01 /doc/src/sgml/catalogs.sgml | |
| parent | e41aed674f35c63380175bb0e2dfa8dccfb2204d (diff) | |
Reorder subskiplsn in pg_subscription to avoid alignment issues.
The column 'subskiplsn' uses TYPALIGN_DOUBLE (which has 4 bytes alignment
on AIX) for storage. But the C Struct (Form_pg_subscription) has 8-byte
alignment for this field, so retrieving it from storage causes an
unaligned read.
To fix this, we rearranged the 'subskiplsn' column in the catalog so that
it naturally comes at an 8-byte boundary.
We have fixed a similar problem in commit f3b421da5f. This patch adds a
test to avoid a similar mistake in the future.
Reported-by: Noah Misch
Diagnosed-by: Noah Misch, Masahiko Sawada, Amit Kapila
Author: Masahiko Sawada
Reviewed-by: Noah Misch, Amit Kapila
Discussion: https://postgr.es/m/[email protected]
https://postgr.es/m/CAD21AoDeScrsHhLyEPYqN3sydg6PxAPVBboK=30xJfUVihNZDA@mail.gmail.com
Diffstat (limited to 'doc/src/sgml/catalogs.sgml')
| -rw-r--r-- | doc/src/sgml/catalogs.sgml | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index 298de74af43..646ab74d049 100644 --- a/doc/src/sgml/catalogs.sgml +++ b/doc/src/sgml/catalogs.sgml @@ -7825,6 +7825,16 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l <row> <entry role="catalog_table_entry"><para role="column_definition"> + <structfield>subskiplsn</structfield> <type>pg_lsn</type> + </para> + <para> + Finish LSN of the transaction whose changes are to be skipped, if a valid + LSN; otherwise <literal>0/0</literal>. + </para></entry> + </row> + + <row> + <entry role="catalog_table_entry"><para role="column_definition"> <structfield>subname</structfield> <type>name</type> </para> <para> @@ -7895,16 +7905,6 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l <row> <entry role="catalog_table_entry"><para role="column_definition"> - <structfield>subskiplsn</structfield> <type>pg_lsn</type> - </para> - <para> - Finish LSN of the transaction whose changes are to be skipped, if a valid - LSN; otherwise <literal>0/0</literal>. - </para></entry> - </row> - - <row> - <entry role="catalog_table_entry"><para role="column_definition"> <structfield>subconninfo</structfield> <type>text</type> </para> <para> |