diff options
| author | Amit Kapila | 2024-02-07 04:34:04 +0000 |
|---|---|---|
| committer | Amit Kapila | 2024-02-07 04:34:04 +0000 |
| commit | 22f7e61a63306873211e26c7bac9c68631309aef (patch) | |
| tree | 554a9d76449e79eee15b158aa2ce3b5be8a7dd66 /doc/src | |
| parent | b9d6038d7048ddb837aa1d286fb8f5ca0e9b3a83 (diff) | |
Clean-ups for 776621a5e4 and 7329240437.
Following are a few clean-ups related to failover option support in slots:
1. Improve the documentation in create_subscription.sgml.
2. Remove the spurious blank line in subscriptioncmds.c.
3. Remove the NOTICE for alter_replication_slot in subscriptioncmds.c as
we would sometimes print it even when nothing has changed. One can find
the change by enabling log_replication_commands on the publisher.
4. Optimize ReplicationSlotAlter() function to prevent disk flushing when
the slot's data remains unchanged.
Author: Hou Zhijie
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/[email protected]
Discussion: https://postgr.es/m/OS0PR01MB57164904651FB588A518E98894472@OS0PR01MB5716.jpnprd01.prod.outlook.com
Diffstat (limited to 'doc/src')
| -rw-r--r-- | doc/src/sgml/ref/create_subscription.sgml | 5 | ||||
| -rw-r--r-- | doc/src/sgml/ref/pg_dump.sgml | 4 |
2 files changed, 3 insertions, 6 deletions
diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index ee89ffb1d12..15794731bbb 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -117,9 +117,8 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl command should connect to the publisher at all. The default is <literal>true</literal>. Setting this to <literal>false</literal> will force the values of - <literal>create_slot</literal>, <literal>enabled</literal>, - <literal>copy_data</literal>, and <literal>failover</literal> - to <literal>false</literal>. + <literal>create_slot</literal>, <literal>enabled</literal> and + <literal>copy_data</literal> to <literal>false</literal>. (You cannot combine setting <literal>connect</literal> to <literal>false</literal> with setting <literal>create_slot</literal>, <literal>enabled</literal>, diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml index f8ae4220e1d..0caf56e0e04 100644 --- a/doc/src/sgml/ref/pg_dump.sgml +++ b/doc/src/sgml/ref/pg_dump.sgml @@ -1591,9 +1591,7 @@ CREATE DATABASE foo WITH TEMPLATE template0; information might have to be changed. If the subscription needs to be enabled for <link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>, - then same needs to be done by executing - <link linkend="sql-altersubscription-params-set"> - <literal>ALTER SUBSCRIPTION ... SET (failover = true)</literal></link> + execute <link linkend="sql-altersubscription-params-set"><literal>ALTER SUBSCRIPTION ... SET (failover = true)</literal></link> after the slot has been created. It might also be appropriate to truncate the target tables before initiating a new full table copy. If users intend to copy initial data during refresh they must create the slot with |