diff options
| author | Heikki Linnakangas | 2013-10-03 08:47:17 +0000 |
|---|---|---|
| committer | Heikki Linnakangas | 2013-10-03 08:51:31 +0000 |
| commit | c2b175b94851e59765cc87243d8faf923e3d820b (patch) | |
| tree | 6b56f8aa03965c61874cbaa9010bde885593e095 /src/backend/access/gin/ginvacuum.c | |
| parent | 627882d0d8ad34c336b98ceb4eb90940fcd392cc (diff) | |
Minor GIN code refactoring.
It makes for cleaner code to have separate Get/Add functions for PostingItems
and ItemPointers. A few callsites that have to deal with both types need to
be duplicated because of this, but all the callers have to know which one
they're dealing with anyway. Overall, this reduces the amount of casting
required.
Extracted from Alexander Korotkov's larger patch to change the data page
format.
Diffstat (limited to 'src/backend/access/gin/ginvacuum.c')
| -rw-r--r-- | src/backend/access/gin/ginvacuum.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/access/gin/ginvacuum.c b/src/backend/access/gin/ginvacuum.c index b84d3a30de3..bda9c60279a 100644 --- a/src/backend/access/gin/ginvacuum.c +++ b/src/backend/access/gin/ginvacuum.c @@ -210,7 +210,7 @@ ginVacuumPostingTreeLeaves(GinVacuumState *gvs, BlockNumber blkno, bool isRoot, for (i = FirstOffsetNumber; i <= GinPageGetOpaque(page)->maxoff; i++) { - PostingItem *pitem = (PostingItem *) GinDataPageGetItem(page, i); + PostingItem *pitem = GinDataPageGetPostingItem(page, i); if (ginVacuumPostingTreeLeaves(gvs, PostingItemGetBlockNumber(pitem), FALSE, NULL)) isChildHasVoid = TRUE; @@ -283,7 +283,7 @@ ginDeletePage(GinVacuumState *gvs, BlockNumber deleteBlkno, BlockNumber leftBlkn #ifdef USE_ASSERT_CHECKING do { - PostingItem *tod = (PostingItem *) GinDataPageGetItem(parentPage, myoff); + PostingItem *tod = GinDataPageGetPostingItem(parentPage, myoff); Assert(PostingItemGetBlockNumber(tod) == deleteBlkno); } while (0); @@ -422,7 +422,7 @@ ginScanToDelete(GinVacuumState *gvs, BlockNumber blkno, bool isRoot, DataPageDel me->blkno = blkno; for (i = FirstOffsetNumber; i <= GinPageGetOpaque(page)->maxoff; i++) { - PostingItem *pitem = (PostingItem *) GinDataPageGetItem(page, i); + PostingItem *pitem = GinDataPageGetPostingItem(page, i); if (ginScanToDelete(gvs, PostingItemGetBlockNumber(pitem), FALSE, me, i)) i--; |