diff options
| author | Alexander Korotkov | 2018-06-26 12:00:51 +0000 |
|---|---|---|
| committer | Alexander Korotkov | 2018-06-26 12:00:51 +0000 |
| commit | 6ca33a885bf892a7fa34020a2620c83ccec3cdd7 (patch) | |
| tree | a6864e0aa75999cad73918ca580e3f3f4e1bea4c /src/backend/access/nbtree/nbtree.c | |
| parent | c9301deb9bf86aaf9144a66026bc121a3eededee (diff) | |
Increase upper limit for vacuum_cleanup_index_scale_factor
Upper limits for vacuum_cleanup_index_scale_factor GUC and reloption
were initially set to 100.0 in 857f9c36. However, after further
discussion, it appears that some users like to disable B-tree cleanup
index scan completely (assuming there are no deleted pages).
vacuum_cleanup_index_scale_factor is used barely to protect against
stalled index statistics. And after detailed consideration it appears
that risk of stalled index statistics is low. And it would be nice to
allow advanced users setting higher values of
vacuum_cleanup_index_scale_factor. So, set upper limit for these
GUC and reloption to DBL_MAX.
Author: Alexander Korotkov
Reviewed-by: Masahiko Sawada
Discussion: https://postgr.es/m/CAC8Q8tJCb%3DgxhzcV7T6ctx7PY-Ux1oA-AsTJc6cAVNsQiYcCzA%40mail.gmail.com
Diffstat (limited to 'src/backend/access/nbtree/nbtree.c')
| -rw-r--r-- | src/backend/access/nbtree/nbtree.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/backend/access/nbtree/nbtree.c b/src/backend/access/nbtree/nbtree.c index 27a3032e42a..cdd0403e1d8 100644 --- a/src/backend/access/nbtree/nbtree.c +++ b/src/backend/access/nbtree/nbtree.c @@ -816,6 +816,7 @@ _bt_vacuum_needs_cleanup(IndexVacuumInfo *info) { StdRdOptions *relopts; float8 cleanup_scale_factor; + float8 prev_num_heap_tuples; /* * If table receives enough insertions and no cleanup was performed, @@ -829,11 +830,12 @@ _bt_vacuum_needs_cleanup(IndexVacuumInfo *info) relopts->vacuum_cleanup_index_scale_factor >= 0) ? relopts->vacuum_cleanup_index_scale_factor : vacuum_cleanup_index_scale_factor; + prev_num_heap_tuples = metad->btm_last_cleanup_num_heap_tuples; if (cleanup_scale_factor <= 0 || - metad->btm_last_cleanup_num_heap_tuples < 0 || - info->num_heap_tuples > (1.0 + cleanup_scale_factor) * - metad->btm_last_cleanup_num_heap_tuples) + prev_num_heap_tuples < 0 || + (info->num_heap_tuples - prev_num_heap_tuples) / + prev_num_heap_tuples >= cleanup_scale_factor) result = true; } |