diff options
| author | Peter Geoghegan | 2020-01-01 19:32:07 +0000 |
|---|---|---|
| committer | Peter Geoghegan | 2020-01-01 19:32:07 +0000 |
| commit | c5f3b53b0ef2e8ae78e7488148c12bfe5939ca17 (patch) | |
| tree | 18d3beec95e9163b8571abcccfdec56cbdffa6e6 /src/backend/access/nbtree/nbtree.c | |
| parent | 7559d8ebfa11d98728e816f6b655582ce41150f3 (diff) | |
Update btree_xlog_delete() comments.
Commit fe97c61c updated LP_DEAD item deletion comments, but missed a
minor discrepancy on the REDO side. Fix it now.
In passing, don't talk about the btree_xlog_vacuum() behavior within
btree_xlog_delete(). The reliance on XLOG_HEAP2_CLEANUP_INFO records
for recovery conflicts is already discussed within btvacuumpage() and
mentioned again in passing above btree_xlog_vacuum(), which seems
sufficient.
Diffstat (limited to 'src/backend/access/nbtree/nbtree.c')
| -rw-r--r-- | src/backend/access/nbtree/nbtree.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/backend/access/nbtree/nbtree.c b/src/backend/access/nbtree/nbtree.c index f9e94c28c5b..8376a5e6b75 100644 --- a/src/backend/access/nbtree/nbtree.c +++ b/src/backend/access/nbtree/nbtree.c @@ -1208,9 +1208,10 @@ restart: * as long as the callback function only considers whether the * index tuple refers to pre-cutoff heap tuples that were * certainly already pruned away during VACUUM's initial heap - * scan by the time we get here. (We can rely on conflicts - * produced by heap pruning, rather than producing our own - * now.) + * scan by the time we get here. (XLOG_HEAP2_CLEANUP_INFO + * records produce conflicts using a latestRemovedXid value + * for the entire VACUUM, so there is no need to produce our + * own conflict now.) * * Backends with snapshots acquired after a VACUUM starts but * before it finishes could have a RecentGlobalXmin with a |