Remove PushOverrideSearchPath() and PopOverrideSearchPath().

Since commit 681d9e4621aac0a9c71364b6f54f00f6d8c4337f, they have no in-tree
calls.  Any new calls would introduce security vulnerabilities like the one
fixed in that commit.

Alexander Lakhin, reviewed by Aleksander Alekseev.

Discussion: https://postgr.es/m/[email protected]

1 files changed, 0 insertions, 5 deletions

diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c
index 9a2ee1c6008..4cc994ca31e 100644
--- a/src/backend/commands/extension.c
+++ b/src/backend/commands/extension.c
@@ -967,11 +967,6 @@ execute_extension_script(Oid extensionOid, ExtensionControlFile *control,
 	 * searched anyway.  (Listing pg_catalog explicitly in a non-first
 	 * position would be bad for security.)  Finally add pg_temp to ensure
 	 * that temp objects can't take precedence over others.
-	 *
-	 * Note: it might look tempting to use PushOverrideSearchPath for this,
-	 * but we cannot do that.  We have to actually set the search_path GUC in
-	 * case the extension script examines or changes it.  In any case, the
-	 * GUC_ACTION_SAVE method is just as convenient.
 	 */
 	initStringInfo(&pathbuf);
 	appendStringInfoString(&pathbuf, quote_identifier(schemaName));