diff options
| author | Tom Lane | 2004-05-31 19:24:05 +0000 |
|---|---|---|
| committer | Tom Lane | 2004-05-31 19:24:05 +0000 |
| commit | e674707968059459960304981fc0a1d7a6049e24 (patch) | |
| tree | f276eafb51fa96700fd49a3e7bb309516fbec280 /src/backend/commands/vacuum.c | |
| parent | a843053e2e596da640d2afc73eeaa1f9273fff38 (diff) | |
Minor code rationalization: FlushRelationBuffers just returns void,
rather than an error code, and does elog(ERROR) not elog(WARNING)
when it detects a problem. All callers were simply elog(ERROR)'ing on
failure return anyway, and I find it hard to envision a caller that would
not, so we may as well simplify the callers and produce the more useful
error message directly.
Diffstat (limited to 'src/backend/commands/vacuum.c')
| -rw-r--r-- | src/backend/commands/vacuum.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c index b2ebda8e975..aa6491af1c0 100644 --- a/src/backend/commands/vacuum.c +++ b/src/backend/commands/vacuum.c @@ -13,7 +13,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/vacuum.c,v 1.278 2004/05/26 04:41:12 neilc Exp $ + * $PostgreSQL: pgsql/src/backend/commands/vacuum.c,v 1.279 2004/05/31 19:24:05 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1031,9 +1031,7 @@ full_vacuum_rel(Relation onerel, VacuumStmt *vacstmt) * tuples have correct on-row commit status on disk (see * bufmgr.c's comments for FlushRelationBuffers()). */ - i = FlushRelationBuffers(onerel, vacrelstats->rel_pages); - if (i < 0) - elog(ERROR, "FlushRelationBuffers returned %d", i); + FlushRelationBuffers(onerel, vacrelstats->rel_pages); } } @@ -2542,9 +2540,7 @@ repair_frag(VRelStats *vacrelstats, Relation onerel, * tuples have correct on-row commit status on disk (see bufmgr.c's * comments for FlushRelationBuffers()). */ - i = FlushRelationBuffers(onerel, blkno); - if (i < 0) - elog(ERROR, "FlushRelationBuffers returned %d", i); + FlushRelationBuffers(onerel, blkno); /* truncate relation, if needed */ if (blkno < nblocks) @@ -2606,9 +2602,7 @@ vacuum_heap(VRelStats *vacrelstats, Relation onerel, VacPageList vacuum_pages) Assert(vacrelstats->rel_pages >= vacuum_pages->empty_end_pages); relblocks = vacrelstats->rel_pages - vacuum_pages->empty_end_pages; - i = FlushRelationBuffers(onerel, relblocks); - if (i < 0) - elog(ERROR, "FlushRelationBuffers returned %d", i); + FlushRelationBuffers(onerel, relblocks); /* truncate relation if there are some empty end-pages */ if (vacuum_pages->empty_end_pages > 0) |