diff options
| author | Tom Lane | 2024-01-10 18:51:36 +0000 |
|---|---|---|
| committer | Tom Lane | 2024-01-10 18:51:36 +0000 |
| commit | add673b897c3d76767cec5ac1619fad6b1eb7582 (patch) | |
| tree | 8b89cfdd841f37211bb46cefab10a2a3384fb7d7 /src/backend/optimizer/path/joinpath.c | |
| parent | d641b827af3966e349cbcc592bc51a4ab770c37b (diff) | |
Fix Asserts in calc_non_nestloop_required_outer().
These were not testing the same thing as the comparable Assert
in calc_nestloop_required_outer(), because we neglected to map
the given Paths' relids to top-level relids. When considering
a partition child join the latter is the correct thing to do.
This oversight is old, but since it's only an overly-weak Assert
check there doesn't seem to be much value in back-patching.
Richard Guo (with cosmetic changes and comment updates by me)
Discussion: https://postgr.es/m/CAMbWs49sqbe9GBZ8sy8dSfKRNURgicR85HX8vgzcgQsPF0XY1w@mail.gmail.com
Diffstat (limited to 'src/backend/optimizer/path/joinpath.c')
| -rw-r--r-- | src/backend/optimizer/path/joinpath.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/optimizer/path/joinpath.c b/src/backend/optimizer/path/joinpath.c index 3fd5a24fadc..e9def9d540a 100644 --- a/src/backend/optimizer/path/joinpath.c +++ b/src/backend/optimizer/path/joinpath.c @@ -730,8 +730,11 @@ try_nestloop_path(PlannerInfo *root, return; /* - * Paths are parameterized by top-level parents, so run parameterization - * tests on the parent relids. + * Any parameterization of the input paths refers to topmost parents of + * the relevant relations, because reparameterize_path_by_child() hasn't + * been called yet. So we must consider topmost parents of the relations + * being joined, too, while determining parameterization of the result and + * checking for disallowed parameterization cases. */ if (innerrel->top_parent_relids) innerrelids = innerrel->top_parent_relids; |