diff options
| author | Tom Lane | 2019-05-05 17:10:07 +0000 |
|---|---|---|
| committer | Tom Lane | 2019-05-05 17:10:07 +0000 |
| commit | 9691aa72e2a7fb146ac759e1f8a8b04962128cc0 (patch) | |
| tree | 1a21f675aad53fbb043617a6bcff28c312758013 /src/backend/optimizer/util/appendinfo.c | |
| parent | 62148c3520b562e518f17134b22120bab0cb113b (diff) | |
Fix style violations in syscache lookups.
Project style is to check the success of SearchSysCacheN and friends
by applying HeapTupleIsValid to the result. A tiny minority of calls
creatively did it differently. Bring them into line with the rest.
This is just cosmetic, since HeapTupleIsValid is indeed just a null
check at the moment ... but that may not be true forever, and in any
case it puts a mental burden on readers who may wonder why these
call sites are not like the rest.
Back-patch to v11 just to keep the branches in sync. (The bulk of these
errors seem to have originated in v11 or v12, though a few are old.)
Per searching to see if anyplace else had made the same error
repaired in 62148c352.
Diffstat (limited to 'src/backend/optimizer/util/appendinfo.c')
| -rw-r--r-- | src/backend/optimizer/util/appendinfo.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/optimizer/util/appendinfo.c b/src/backend/optimizer/util/appendinfo.c index ca6622ece9b..ba955290b10 100644 --- a/src/backend/optimizer/util/appendinfo.c +++ b/src/backend/optimizer/util/appendinfo.c @@ -134,7 +134,7 @@ make_inh_translation_list(Relation oldrelation, Relation newrelation, HeapTuple newtup; newtup = SearchSysCacheAttName(new_relid, attname); - if (!newtup) + if (!HeapTupleIsValid(newtup)) elog(ERROR, "could not find inherited attribute \"%s\" of relation \"%s\"", attname, RelationGetRelationName(newrelation)); new_attno = ((Form_pg_attribute) GETSTRUCT(newtup))->attnum - 1; |