diff options
| author | Tom Lane | 2011-04-22 21:43:18 +0000 |
|---|---|---|
| committer | Tom Lane | 2011-04-22 21:43:18 +0000 |
| commit | 9e9b9ac7d1860fbb98eb4db17a94ff25524b6447 (patch) | |
| tree | b8505f0c0aa817e1611f43d130248fa7bbb2103c /src/backend/parser/parse_cte.c | |
| parent | 0cfdc1c657b7c2aa1e4524f495e84005f750ec02 (diff) | |
Make a code-cleanup pass over the collations patch.
This patch is almost entirely cosmetic --- mostly cleaning up a lot of
neglected comments, and fixing code layout problems in places where the
patch made lines too long and then pgindent did weird things with that.
I did find a bug-of-omission in equalTupleDescs().
Diffstat (limited to 'src/backend/parser/parse_cte.c')
| -rw-r--r-- | src/backend/parser/parse_cte.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/backend/parser/parse_cte.c b/src/backend/parser/parse_cte.c index 41097263b41..ec6afd83b6c 100644 --- a/src/backend/parser/parse_cte.c +++ b/src/backend/parser/parse_cte.c @@ -286,10 +286,10 @@ analyzeCTE(ParseState *pstate, CommonTableExpr *cte) else { /* - * Verify that the previously determined output column types match - * what the query really produced. We have to check this because the - * recursive term could have overridden the non-recursive term, and we - * don't have any easy way to fix that. + * Verify that the previously determined output column types and + * collations match what the query really produced. We have to check + * this because the recursive term could have overridden the + * non-recursive term, and we don't have any easy way to fix that. */ ListCell *lctlist, *lctyp, @@ -366,11 +366,11 @@ analyzeCTETargetList(ParseState *pstate, CommonTableExpr *cte, List *tlist) Assert(cte->ctecolnames == NIL); /* - * We need to determine column names and types. The alias column names - * override anything coming from the query itself. (Note: the SQL spec - * says that the alias list must be empty or exactly as long as the output - * column set; but we allow it to be shorter for consistency with Alias - * handling.) + * We need to determine column names, types, and collations. The alias + * column names override anything coming from the query itself. (Note: + * the SQL spec says that the alias list must be empty or exactly as long + * as the output column set; but we allow it to be shorter for consistency + * with Alias handling.) */ cte->ctecolnames = copyObject(cte->aliascolnames); cte->ctecoltypes = cte->ctecoltypmods = cte->ctecolcollations = NIL; |
