diff options
| author | Michael Paquier | 2024-03-12 01:02:54 +0000 |
|---|---|---|
| committer | Michael Paquier | 2024-03-12 01:02:54 +0000 |
| commit | 2c8118ee5d980e11f73683fcda2329c323aa381e (patch) | |
| tree | 7527eb2a94bc9cc8821ff9afba62e03918dff351 /src/bin/pg_upgrade/version.c | |
| parent | 3045324214467dd3f0bef31f6f33562b9eb93aa3 (diff) | |
Use printf's %m format instead of strerror(errno) in more places
Most callers of strerror() are removed from the backend code. The
remaining callers require special handling with a saved errno from a
previous system call. The frontend code still needs strerror() where
error states need to be handled outside of fprintf.
Note that pg_regress is not changed to use %m as the TAP output may
clobber errno, since those functions call fprintf() and friends before
evaluating the format string.
Support for %m in src/port/snprintf.c has been added in d6c55de1f99a,
hence all the stable branches currently supported include it.
Author: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/[email protected]
Diffstat (limited to 'src/bin/pg_upgrade/version.c')
| -rw-r--r-- | src/bin/pg_upgrade/version.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/bin/pg_upgrade/version.c b/src/bin/pg_upgrade/version.c index 13b2c0f0128..9dc1399f368 100644 --- a/src/bin/pg_upgrade/version.c +++ b/src/bin/pg_upgrade/version.c @@ -113,8 +113,7 @@ check_for_data_types_usage(ClusterInfo *cluster, { found = true; if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL) - pg_fatal("could not open file \"%s\": %s", output_path, - strerror(errno)); + pg_fatal("could not open file \"%s\": %m", output_path); if (!db_used) { fprintf(script, "In database: %s\n", active_db->db_name); @@ -289,8 +288,7 @@ old_9_6_invalidate_hash_indexes(ClusterInfo *cluster, bool check_mode) if (!check_mode) { if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL) - pg_fatal("could not open file \"%s\": %s", output_path, - strerror(errno)); + pg_fatal("could not open file \"%s\": %m", output_path); if (!db_used) { PQExpBufferData connectbuf; @@ -423,8 +421,7 @@ report_extension_updates(ClusterInfo *cluster) for (rowno = 0; rowno < ntups; rowno++) { if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL) - pg_fatal("could not open file \"%s\": %s", output_path, - strerror(errno)); + pg_fatal("could not open file \"%s\": %m", output_path); if (!db_used) { PQExpBufferData connectbuf; |