diff options
| author | Peter Eisentraut | 2021-10-12 19:14:50 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2021-10-12 19:20:29 +0000 |
| commit | 390edeeb570c01de1a14e2985ffed96de001e42e (patch) | |
| tree | b68773d8896d0b4b8494e4006b73003f6ba37848 /src/bin/psql/describe.c | |
| parent | 00c61a74bcdbc04a3db721d53c7aff62244da198 (diff) | |
psql: Fix some scan-build warnings
A repeated complaint was that scan-build thought that if the \timing
setting changes during processing of a query, the post-processing
might read garbage time values. This is probably not possible right
now, but it's not entirely inconceivable given the code structure. So
silence this warning with small restructuring that makes this more
robust. The other warnings were a few dead stores that are easy to
remove.
Discussion: https://www.postgresql.org/message-id/[email protected]
Diffstat (limited to 'src/bin/psql/describe.c')
| -rw-r--r-- | src/bin/psql/describe.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index a33d77c0efc..ea4ca5c05c2 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -635,7 +635,6 @@ describeFunctions(const char *functypes, const char *func_pattern, appendPQExpBufferStr(&buf, "p.prokind = 'w'\n"); else appendPQExpBufferStr(&buf, "p.proiswindow\n"); - needs_or = true; } appendPQExpBufferStr(&buf, " )\n"); } |