diff options
| author | Tom Lane | 2011-10-21 20:36:04 +0000 |
|---|---|---|
| committer | Tom Lane | 2011-10-21 20:36:04 +0000 |
| commit | f9c92a5a3ead738c7de0dffa203a92b4d2fec413 (patch) | |
| tree | 75038afe9cf2de5eecea6f24079e3f011d576e97 /src/include | |
| parent | 5ac5980744149f062ec599015ffe7a7689dd117b (diff) | |
Code review for pgstat_get_crashed_backend_activity patch.
Avoid possibly dumping core when pgstat_track_activity_query_size has a
less-than-default value; avoid uselessly searching for the query string
of a successfully-exited backend; don't bother putting out an ERRDETAIL if
we don't have a query to show; some other minor stylistic improvements.
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/pgstat.h | 2 | ||||
| -rw-r--r-- | src/include/utils/ascii.h | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/src/include/pgstat.h b/src/include/pgstat.h index d0f1927efb2..7b2bd4edc0e 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -721,7 +721,7 @@ extern void pgstat_report_xact_timestamp(TimestampTz tstamp); extern void pgstat_report_waiting(bool waiting); extern const char *pgstat_get_backend_current_activity(int pid, bool checkUser); extern const char *pgstat_get_crashed_backend_activity(int pid, char *buffer, - int len); + int buflen); extern PgStat_TableStatus *find_tabstat_entry(Oid rel_id); extern PgStat_BackendFunctionEntry *find_funcstat_entry(Oid func_id); diff --git a/src/include/utils/ascii.h b/src/include/utils/ascii.h index adeddb5626f..b57713b3eb1 100644 --- a/src/include/utils/ascii.h +++ b/src/include/utils/ascii.h @@ -16,6 +16,7 @@ extern Datum to_ascii_encname(PG_FUNCTION_ARGS); extern Datum to_ascii_enc(PG_FUNCTION_ARGS); extern Datum to_ascii_default(PG_FUNCTION_ARGS); -extern void ascii_safe_strncpy(char *dest, const char *src, int len); + +extern void ascii_safe_strlcpy(char *dest, const char *src, size_t destsiz); #endif /* _ASCII_H_ */ |