diff options
| author | Andres Freund | 2025-04-04 19:15:39 +0000 |
|---|---|---|
| committer | Andres Freund | 2025-04-06 16:07:02 +0000 |
| commit | 57dec20fd4691900fbe118699d32640fc538dc20 (patch) | |
| tree | 0a06038dd8d608e5034dcf53bd4adabebb713ed9 /src | |
| parent | 8ab6ef2bb8d9a00d205742932eb0b6daf62b34e0 (diff) | |
aio: Avoid spurious coverity warning
PgAioResult.result is never accessed in the relevant path, but coverity
complains about an uninitialized access anyway. So just zero-initialize the
whole thing. While at it, reduce the scope of the variable.
Reported-by: Ranier Vilela <[email protected]>
Reviewed-by: Noah Misch <[email protected]>
Discussion: https://postgr.es/m/CAEudQApsKqd-s+fsUQ0OmxJAMHmBSXxrAz3dCs+uvqb3iRtjSw@mail.gmail.com
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/storage/buffer/bufmgr.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index 1c37d7dfe2f..ffaca5ee54d 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -6868,8 +6868,6 @@ buffer_readv_complete_one(PgAioTargetData *td, uint8 buf_off, Buffer buffer, /* Check for garbage data. */ if (!failed) { - PgAioResult result_one; - if (!PageIsVerified((Page) bufdata, tag.blockNum, piv_flags, failed_checksum)) { @@ -6904,6 +6902,8 @@ buffer_readv_complete_one(PgAioTargetData *td, uint8 buf_off, Buffer buffer, */ if (*buffer_invalid || *failed_checksum || *zeroed_buffer) { + PgAioResult result_one = {0}; + buffer_readv_encode_error(&result_one, is_temp, *zeroed_buffer, *ignored_checksum, |