diff options
| author | Bruce Momjian | 2000-03-23 17:27:36 +0000 |
|---|---|---|
| committer | Bruce Momjian | 2000-03-23 17:27:36 +0000 |
| commit | b2d867fb086c2b8c504387d177b80b9d09b76370 (patch) | |
| tree | 668d491727e83dcbae3962b730851e53620e8e5b /src | |
| parent | 90cb4c89dffae564a8ab803e9f0213625207afe7 (diff) | |
Some points for portability improvements:
1. C++ style comments in C source for ecpg ( // comment )
2. compiler finds wrong include file extern.h in ecpg/lib/descriptor.c
from
include path instead of workdir (rename it ?)
3. fe-connect getsockopt takes a socklen_t as fifth arg not int (use
SOCKET_SIZE_TYPE instead)
4. char vs unsigned char in psql calls to libpq
5. empty define that results in an empty but terminated line ( ; )
Now for all but point 3 I can supply changes to the
compiler flags, to make the compiler less pedantic.
Or is someone interested in the complications ?
in the meantime can someone apply the attached patch ?
Andreas
Diffstat (limited to 'src')
| -rw-r--r-- | src/interfaces/libpq/fe-connect.c | 4 | ||||
| -rw-r--r-- | src/template/aix_42 | 2 | ||||
| -rw-r--r-- | src/test/regress/resultmap | 2 |
3 files changed, 5 insertions, 3 deletions
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c index 81973e34f63..ad1d13fdf2a 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.123 2000/03/11 03:08:36 tgl Exp $ + * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.124 2000/03/23 17:27:29 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -1080,7 +1080,7 @@ PQconnectPoll(PGconn *conn) #else char optval; #endif - int optlen = sizeof(optval); + SOCKET_SIZE_TYPE optlen = sizeof(optval); /* Write ready, since we've made it here, so the connection * has been made. */ diff --git a/src/template/aix_42 b/src/template/aix_42 index 49f3a690413..a0ed5a9c04a 100644 --- a/src/template/aix_42 +++ b/src/template/aix_42 @@ -1,5 +1,5 @@ AROPT:crs -CFLAGS:-qchars=signed -qmaxmem=8192 -qhalt=w -qsrcmsg -qcheck=divzero -qlonglong +CFLAGS:-O2 -qmaxmem=16384 -qhalt=w -qsrcmsg -qlanglvl=extended -qlonglong -qcpluscmt SHARED_LIB:-lc ALL: SRCH_INC: diff --git a/src/test/regress/resultmap b/src/test/regress/resultmap index faa8577f2c2..a325a3be0d1 100644 --- a/src/test/regress/resultmap +++ b/src/test/regress/resultmap @@ -15,6 +15,8 @@ int4/powerpc-unknown-linux-gnu=int4-not-representable int2/.*-qnx4=int2-too-large int4/.*-qnx4=int4-too-large int8/.*-qnx4=int8-exp-three-digits +int2/.*-aix4=int2-too-large +int4/.*-aix4=int4-too-large float8/alpha-dec-osf=float8-fp-exception float4/.*-qnx4=float4-exp-three-digits float8/.*-qnx4=float8-exp-three-digits |