diff options
| author | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-01-28 21:07:13 +0000 |
|---|---|---|
| committer | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-01-28 21:07:13 +0000 |
| commit | 26b3dc49226011469bfe29af0f882b06215388a5 (patch) | |
| tree | c8f15ef36f942670aad19d6e62af38fd94af158f | |
| parent | 2e126959299f6b12c29d8243a1e7fe1fae2c9fd2 (diff) | |
uri/common: reduce allocations and retained objects
Thanks to Sam Saffron for this patch, it shows
a nice reduction which affects many web applications:
require 'memory_profiler'
MemoryProfiler.report do
require 'uri'
end.pretty_print
Before:
Total allocated: 986643 bytes (15159 objects)
Total retained: 246370 bytes (2532 objects)
After:
Total allocated: 926903 bytes (13665 objects)
Total retained: 208570 bytes (1587 objects)
* lib/uri/common.rb: reduce allocations and retained objects
[ruby-core:85161] [Feature #14410]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
| -rw-r--r-- | lib/uri/common.rb | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/lib/uri/common.rb b/lib/uri/common.rb index 764f89d810..292708c152 100644 --- a/lib/uri/common.rb +++ b/lib/uri/common.rb @@ -1,4 +1,4 @@ -# frozen_string_literal: false +# frozen_string_literal: true #-- # = uri/common.rb # @@ -342,17 +342,17 @@ module URI TBLENCWWWCOMP_ = {} # :nodoc: 256.times do |i| - TBLENCWWWCOMP_[i.chr] = '%%%02X' % i + TBLENCWWWCOMP_[-i.chr] = -('%%%02X' % i) end TBLENCWWWCOMP_[' '] = '+' TBLENCWWWCOMP_.freeze TBLDECWWWCOMP_ = {} # :nodoc: 256.times do |i| h, l = i>>4, i&15 - TBLDECWWWCOMP_['%%%X%X' % [h, l]] = i.chr - TBLDECWWWCOMP_['%%%x%X' % [h, l]] = i.chr - TBLDECWWWCOMP_['%%%X%x' % [h, l]] = i.chr - TBLDECWWWCOMP_['%%%x%x' % [h, l]] = i.chr + TBLDECWWWCOMP_[-('%%%X%X' % [h, l])] = -i.chr + TBLDECWWWCOMP_[-('%%%x%X' % [h, l])] = -i.chr + TBLDECWWWCOMP_[-('%%%X%x' % [h, l])] = -i.chr + TBLDECWWWCOMP_[-('%%%x%x' % [h, l])] = -i.chr end TBLDECWWWCOMP_['+'] = ' ' TBLDECWWWCOMP_.freeze @@ -468,7 +468,7 @@ module URI if isindex if sep.empty? val = key - key = '' + key = +'' end isindex = false end @@ -482,7 +482,7 @@ module URI if val val.gsub!(/\+|%\h\h/, TBLDECWWWCOMP_) else - val = '' + val = +'' end ary << [key, val] |