diff options
author | naruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2016-07-02 09:05:05 +0000 |
---|---|---|
committer | naruse <naruse@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2016-07-02 09:05:05 +0000 |
commit | 79f86a67d06919e0c8a4a893eae6e91ca3d74dc3 (patch) | |
tree | e26741e3eb04e1be981dda6231009b75a8b9f472 | |
parent | 1e3fc7dcfae209ab511eb5194d626de021be69e7 (diff) |
* lib/uri/mailto.rb (initialize): RFC3986_Parser#split sets opaque
only if the URI has path-rootless, not path-empty.
[ruby-core:76055] [Bug #12498]
patched by Chris Heisterkamp <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55563 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | ChangeLog | 7 | ||||
-rw-r--r-- | lib/uri/mailto.rb | 3 | ||||
-rw-r--r-- | test/uri/test_mailto.rb | 10 |
3 files changed, 16 insertions, 4 deletions
@@ -1,3 +1,10 @@ +Sat Jul 2 18:04:24 2016 NARUSE, Yui <[email protected]> + + * lib/uri/mailto.rb (initialize): RFC3986_Parser#split sets opaque + only if the URI has path-rootless, not path-empty. + [ruby-core:76055] [Bug #12498] + patched by Chris Heisterkamp <[email protected]> + Sat Jul 2 04:26:14 2016 NARUSE, Yui <[email protected]> * regcomp.c (noname_disable_map): don't optimize out group 0 diff --git a/lib/uri/mailto.rb b/lib/uri/mailto.rb index 495f939a3b..7299550d3f 100644 --- a/lib/uri/mailto.rb +++ b/lib/uri/mailto.rb @@ -136,6 +136,9 @@ module URI @to = nil @headers = [] + # The RFC3986 parser does not normally populate opaque + @opaque = "?#{@query}" if @query && !@opaque + unless @opaque raise InvalidComponentError, "missing opaque part for mailto URL" diff --git a/test/uri/test_mailto.rb b/test/uri/test_mailto.rb index 4e3b0425fa..c09b001e0f 100644 --- a/test/uri/test_mailto.rb +++ b/test/uri/test_mailto.rb @@ -112,13 +112,15 @@ class TestMailTo < Test::Unit::TestCase bad << ["[email protected]?subject=1+1=2", []] ok.each do |x| - assert_equal(x[0], - @u.build(x[1]).to_s) - assert_equal(x[0], - @u.build(x[2]).to_s) + assert_equal(x[0], URI.parse(x[0]).to_s) + assert_equal(x[0], @u.build(x[1]).to_s) + assert_equal(x[0], @u.build(x[2]).to_s) end bad.each do |x| + assert_raise(URI::InvalidURIError) { + URI.parse(x) + } assert_raise(URI::InvalidComponentError) { @u.build(x) } |