diff options
author | 卜部昌平 <[email protected]> | 2020-04-10 14:11:40 +0900 |
---|---|---|
committer | 卜部昌平 <[email protected]> | 2020-04-13 16:06:00 +0900 |
commit | 4ff3f205408ff8bb413d69151105d301858136ba (patch) | |
tree | 0494fea3f4cdb82ec1d34e462438389dfea8b8da /internal/variable.h | |
parent | a3f6f67967644f34226b4424227d2eec52fedd45 (diff) |
add #include guard hack
According to MSVC manual (*1), cl.exe can skip including a header file
when that:
- contains #pragma once, or
- starts with #ifndef, or
- starts with #if ! defined.
GCC has a similar trick (*2), but it acts more stricter (e. g. there
must be _no tokens_ outside of #ifndef...#endif).
Sun C lacked #pragma once for a looong time. Oracle Developer Studio
12.5 finally implemented it, but we cannot assume such recent version.
This changeset modifies header files so that each of them include
strictly one #ifndef...#endif. I believe this is the most portable way
to trigger compiler optimizations. [Bug #16770]
*1: https://docs.microsoft.com/en-us/cpp/preprocessor/once
*2: https://gcc.gnu.org/onlinedocs/cppinternals/Guard-Macros.html
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3023
Diffstat (limited to 'internal/variable.h')
-rw-r--r-- | internal/variable.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/internal/variable.h b/internal/variable.h index fb0b4a47e8..a3b8f7963d 100644 --- a/internal/variable.h +++ b/internal/variable.h @@ -1,4 +1,6 @@ -/** \noop-*-C-*-vi:ft=c +#ifndef INTERNAL_VARIABLE_H /*-*-C-*-vi:se ft=c:*/ +#define INTERNAL_VARIABLE_H +/** * @file * @author Ruby developers <[email protected]> * @copyright This file is a part of the programming language Ruby. @@ -7,8 +9,6 @@ * file COPYING are met. Consult the file for details. * @brief Internal header for variables. */ -#ifndef INTERNAL_VARIABLE_H -#define INTERNAL_VARIABLE_H #include "ruby/3/config.h" #include <stddef.h> /* for size_t */ #include "constant.h" /* for rb_const_entry_t */ |