diff options
author | Jeremy Evans <[email protected]> | 2019-09-21 09:03:36 -0700 |
---|---|---|
committer | Jeremy Evans <[email protected]> | 2019-09-25 12:33:52 -0700 |
commit | 3b302ea8c95d34d5ef072d7e3b326f28a611e479 (patch) | |
tree | 5a0a5cadb3511d6a3ecf4f234abffecafbeec9d8 /lib/delegate.rb | |
parent | 80b5a0ff2a7709367178f29d4ebe1c54122b1c27 (diff) |
Add Module#ruby2_keywords for passing keywords through regular argument splats
This approach uses a flag bit on the final hash object in the regular splat,
as opposed to a previous approach that used a VM frame flag. The hash flag
approach is less invasive, and handles some cases that the VM frame flag
approach does not, such as saving the argument splat array and splatting it
later:
ruby2_keywords def foo(*args)
@args = args
bar
end
def bar
baz(*@args)
end
def baz(*args, **kw)
[args, kw]
end
foo(a:1) #=> [[], {a: 1}]
foo({a: 1}, **{}) #=> [[{a: 1}], {}]
foo({a: 1}) #=> 2.7: [[], {a: 1}] # and warning
foo({a: 1}) #=> 3.0: [[{a: 1}], {}]
It doesn't handle some cases that the VM frame flag handles, such as when
the final hash object is replaced using Hash#merge, but those cases are
probably less common and are unlikely to properly support keyword
argument separation.
Use ruby2_keywords to handle argument delegation in the delegate library.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/2477
Diffstat (limited to 'lib/delegate.rb')
-rw-r--r-- | lib/delegate.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/delegate.rb b/lib/delegate.rb index 03ebfddf4a..a1589ecd08 100644 --- a/lib/delegate.rb +++ b/lib/delegate.rb @@ -75,7 +75,7 @@ class Delegator < BasicObject # # Handles the magic of delegation through \_\_getobj\_\_. # - def method_missing(m, *args, &block) + ruby2_keywords def method_missing(m, *args, &block) r = true target = self.__getobj__ {r = false} |