diff options
author | Stan Lo <[email protected]> | 2023-08-09 15:57:47 +0100 |
---|---|---|
committer | git <[email protected]> | 2023-08-09 14:57:52 +0000 |
commit | ab0f90f1f5583a64a125701e3b08f6620f029eb6 (patch) | |
tree | 2998b14ea2cdb106ea71e5beba2aa38257ac13fe /lib/error_highlight | |
parent | 6acfc50bccf0c201f77c274281ac33920a0a6923 (diff) |
[ruby/irb] Fix nested IRB sessions' history saving
(https://github.com/ruby/irb/pull/652)
1. Dynamically including `HistorySavingAbility` makes things unnecessarily
complicated and should be avoided.
2. Because both `Reline` and `Readline` use a single `HISTORY` constant
to store history data. When nesting IRB sessions, only the first IRB
session should handle history loading and saving so we can avoid
duplicating history.
3. History saving callback should NOT be stored in `IRB.conf` as it's
recreated every time `IRB.setup` is called, which would happen when
nesting IRB sessions.
https://github.com/ruby/irb/commit/0fef0ae160
Diffstat (limited to 'lib/error_highlight')
0 files changed, 0 insertions, 0 deletions