diff options
author | Eileen M. Uchitelle <[email protected]> | 2021-06-14 20:34:57 -0400 |
---|---|---|
committer | GitHub <[email protected]> | 2021-06-14 17:34:57 -0700 |
commit | 2088a457981b0f71a3bfd14871ed5b6f0d090e6a (patch) | |
tree | 3ba3959e6b8b8debb4d18e5ba310595e651d90d9 /lib/ostruct.rb | |
parent | a09ddfc4207cce58693f2226ebbbc4b8f009fb23 (diff) |
[Bug #17880] Set leaf false on opt_setinlinecache (#4565)
This change fixes the bug described in https://bugs.ruby-lang.org/issues/17880.
Checking `ractor_shareable_p` will cause the method to call back into
Ruby. Anything calling this method can't be a leaf instruction,
otherwise it could crash. By adding `attr bool leaf = false` we no
longer crash because it marks the function as not a leaf.
Here's a simplified reproduction script:
```ruby
require "set"
class Id
attr_reader :db_id
def initialize(db_id)
@db_id = db_id
end
def ==(other)
other.class == self.class && other.db_id == db_id
end
alias_method :eql?, :==
def hash
10
end
def <=>(other)
db_id <=> other.db_id if other.is_a?(self.class)
end
end
class Namespace
IDS = Set[
Id.new(1).freeze,
Id.new(2).freeze,
Id.new(3).freeze,
Id.new(4).freeze,
].freeze
class << self
def test?(id)
IDS.include?(id)
end
end
end
p Namespace.test?(Id.new(1))
p Namespace.test?(Id.new(5))
```
Co-authored-by: Aaron Patterson <[email protected]>
Co-authored-by: Aaron Patterson <[email protected]>
Notes
Notes:
Merged-By: k0kubun <[email protected]>
Diffstat (limited to 'lib/ostruct.rb')
0 files changed, 0 insertions, 0 deletions