diff options
| author | Daniel Niknam <[email protected]> | 2021-08-22 01:37:32 +1000 |
|---|---|---|
| committer | Hiroshi SHIBATA <[email protected]> | 2021-08-31 19:06:14 +0900 |
| commit | 19e1d3cdce96b9e58a0947b6fcbabd6da06cbd11 (patch) | |
| tree | 9d3857faf91a4631427b017ea54171d3542f52e6 /lib/rubygems/request.rb | |
| parent | 31c2e6c08eccf77ec24126b9c77a910a4e543293 (diff) | |
[rubygems/rubygems] Using `Gem::PrintableUri` in `Gem::Request` class
The `@uri` variable could be a source URI with a credential. Using `Gem::PrintableUri` to make sure we are redacting sensitive information from it when logging on verbose mode.
https://github.com/rubygems/rubygems/commit/f566787211
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
Diffstat (limited to 'lib/rubygems/request.rb')
| -rw-r--r-- | lib/rubygems/request.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/rubygems/request.rb b/lib/rubygems/request.rb index 16a368e5ae..fdc4c55da0 100644 --- a/lib/rubygems/request.rb +++ b/lib/rubygems/request.rb @@ -184,6 +184,7 @@ class Gem::Request def perform_request(request) # :nodoc: connection = connection_for @uri + uri = Gem::PrintableUri.parse_uri(@uri) retried = false bad_response = false @@ -191,7 +192,7 @@ class Gem::Request begin @requests[connection.object_id] += 1 - verbose "#{request.method} #{@uri}" + verbose "#{request.method} #{uri}" file_name = File.basename(@uri.path) # perform download progress reporter only for gems |