summaryrefslogtreecommitdiff
path: root/sprintf.c
diff options
context:
space:
mode:
authorJean Boussier <[email protected]>2024-09-04 12:52:18 +0200
committerJean Boussier <[email protected]>2024-09-04 16:12:50 +0200
commit294dad22d7ac5f307d567cff897507b9fd9d05e9 (patch)
tree526d20a5a5fc55264df3863ad838b314612d2ceb /sprintf.c
parent2e5a7d768b0b83a8184eb9e2c5a7560de3e5e78a (diff)
Time#strftime: avoid repeated coderange scanning
Followup: a3f589640fd443deea230c27efd6bdfc92f5817f Restarting scanning has a fixed cost. Since we build a string from many small parts, that causes the scan to restart many times. It's much faster to ignore the coderange, if it's needed later it will be faster to scan it in one go. ``` compare-ruby: ruby 3.4.0dev (2024-09-04T11:54:06Z opt-strftime-growth 149480f0ff) +YJIT [arm64-darwin23] built-ruby: ruby 3.4.0dev (2024-09-04T11:55:26Z opt-strftime-coder.. 29a5153cba) +YJIT [arm64-darwin23] warming up... | |compare-ruby|built-ruby| |:---------------------------|-----------:|---------:| |time.strftime("%FT%T") | 1.870M| 2.225M| | | -| 1.19x| |time.strftime("%FT%T.%3N") | 1.731M| 2.068M| | | -| 1.19x| |time.strftime("%FT%T.%6N") | 1.744M| 2.073M| | | -| 1.19x| ``` Cumulative with a3f589640fd443deea230c27efd6bdfc92f5817f: ``` compare-ruby: ruby 3.4.0dev (2024-09-04T11:55:26Z opt-strftime-coder.. 29a5153cba) +YJIT [arm64-darwin23] built-ruby: ruby 3.4.0dev (2024-09-04T12:57:30Z opt-strftime-coder.. 2b938d667a) +YJIT [arm64-darwin23] warming up... | |compare-ruby|built-ruby| |:---------------------------|-----------:|---------:| |time.strftime("%FT%T") | 1.784M| 2.277M| | | -| 1.28x| |time.strftime("%FT%T.%3N") | 1.504M| 2.056M| | | -| 1.37x| |time.strftime("%FT%T.%6N") | 1.489M| 2.094M| | | -| 1.41x| ```
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/11544
Diffstat (limited to 'sprintf.c')
-rw-r--r--sprintf.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/sprintf.c b/sprintf.c
index 4fa531d53e..1d3b3e0d07 100644
--- a/sprintf.c
+++ b/sprintf.c
@@ -1165,7 +1165,9 @@ ruby_vsprintf0(VALUE result, char *p, const char *fmt, va_list ap)
RBASIC_SET_CLASS_RAW(result, klass);
p = RSTRING_PTR(result);
long blen = (char *)f._p - p;
- if (scanned < blen) {
+
+ coderange = ENC_CODERANGE(result);
+ if (coderange != ENC_CODERANGE_UNKNOWN && scanned < blen) {
rb_str_coderange_scan_restartable(p + scanned, p + blen, rb_enc_get(result), &coderange);
ENC_CODERANGE_SET(result, coderange);
}