diff options
| author | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-08-16 23:56:08 +0000 |
|---|---|---|
| committer | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-08-16 23:56:08 +0000 |
| commit | b53fadfd5f200dbd6fe9f4b2a91ebb68618e59bb (patch) | |
| tree | 460743a4634657cb7161c682a6e05b248e7a8d37 /test/lib | |
| parent | 2cf3bd5bb2a7c4724e528577d37a883fe80a1122 (diff) | |
process.c: defaults to close_others false
Arbitrarily closing file descriptors on exec breaks use cases
where a Ruby process sets up a descriptor for non-Ruby children
to use. For example, the "rake foo" target may spawn any number
of subprocesses (Ruby or not) which depends on parsing the "FOO"
environment variable for out_fd:99 and writing to foo.out
FOO=out_fd:99 rake foo 99>>foo.out
Unfortunately, this introduced one incompatibility in
test/lib/test/unit.rb and it now requires explicitly setting
IO#close_on_exec=true
[ruby-core:88007] [Misc #14907]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64399 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'test/lib')
| -rw-r--r-- | test/lib/test/unit.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/lib/test/unit.rb b/test/lib/test/unit.rb index 51c8960c52..7a09466d1c 100644 --- a/test/lib/test/unit.rb +++ b/test/lib/test/unit.rb @@ -145,6 +145,8 @@ module Test r.close if r nil else + r.close_on_exec = true + w.close_on_exec = true @jobserver = [r, w] options[:parallel] ||= 1 end |