diff options
author | Nobuyoshi Nakada <[email protected]> | 2021-02-22 21:34:11 +0900 |
---|---|---|
committer | Nobuyoshi Nakada <[email protected]> | 2021-03-16 15:47:27 +0900 |
commit | de8e6218a3257fe19b46ff0aa157e66f452ac8b7 (patch) | |
tree | 2b0f8e75fb054cde17923f6e2e69ba82eec832ec /test/rdoc/test_rdoc_markdown.rb | |
parent | 10b082064e6ab0943cce4ef43e567d8044c7096d (diff) |
[ruby/rdoc] Fixed CodeFence without blank lines
Currently a fenced code block needs a preceding blank line, it
should not be required, as:
https://github.github.com/gfm/#fenced-code-blocks
> A fenced code block may interrupt a paragraph, and does not
> require a blank line either before or after.
Just recommended:
https://docs.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks
> We recommend placing a blank line before and after code blocks
> to make the raw formatting easier to read.
https://github.com/ruby/rdoc/commit/0e1776caf3
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/4274
Diffstat (limited to 'test/rdoc/test_rdoc_markdown.rb')
-rw-r--r-- | test/rdoc/test_rdoc_markdown.rb | 36 |
1 files changed, 32 insertions, 4 deletions
diff --git a/test/rdoc/test_rdoc_markdown.rb b/test/rdoc/test_rdoc_markdown.rb index 697a1c600d..ad53e9473c 100644 --- a/test/rdoc/test_rdoc_markdown.rb +++ b/test/rdoc/test_rdoc_markdown.rb @@ -143,7 +143,7 @@ a block quote end def test_parse_code_github - doc = parse <<-MD + doc = <<-MD Example: ``` @@ -156,11 +156,25 @@ code goes here para("Example:"), verb("code goes here\n")) - assert_equal expected, doc + assert_equal expected, parse(doc) + assert_equal expected, parse(doc.sub(/^\n/, '')) + + @parser.github = false + + expected = + doc(para("Example:"), + para("<code>\n""code goes here\n</code>")) + + assert_equal expected, parse(doc) + + expected = + doc(para("Example:\n<code>\n""code goes here\n</code>")) + + assert_equal expected, parse(doc.sub(/^\n/, '')) end def test_parse_code_github_format - doc = parse <<-MD + doc = <<-MD Example: ``` ruby @@ -176,7 +190,21 @@ code goes here para("Example:"), code) - assert_equal expected, doc + assert_equal expected, parse(doc) + assert_equal expected, parse(doc.sub(/^\n/, '')) + + @parser.github = false + + expected = + doc(para("Example:"), + para("<code>ruby\n""code goes here\n</code>")) + + assert_equal expected, parse(doc) + + expected = + doc(para("Example:\n<code>ruby\n""code goes here\n</code>")) + + assert_equal expected, parse(doc.sub(/^\n/, '')) end def test_parse_definition_list |