diff options
author | John Hawthorn <[email protected]> | 2022-01-29 06:11:10 -0800 |
---|---|---|
committer | John Hawthorn <[email protected]> | 2022-02-05 18:10:19 -0800 |
commit | c79d2e54748f52c5023b0a1ee441561df9826c17 (patch) | |
tree | 80ccc9c3d71761206e1440a1a734aa285f56bfc8 /test/ruby/test_exception.rb | |
parent | 3e6c6c74dd40280103e953b321e5804054707053 (diff) |
Fix TAG_THROW through require [Bug #18562]
Previously this was being incorrectly swapped with TAG_RAISE in the next
line. This would end up checking the T_IMEMO throw_data to the exception
handling (which calls Module#===). This happened to not break existing
tests because Module#=== returned false when klass is NULL.
This commit handles throw from require correctly by jumping to the tag
retaining the TAG_THROW state.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/5513
Diffstat (limited to 'test/ruby/test_exception.rb')
-rw-r--r-- | test/ruby/test_exception.rb | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/test/ruby/test_exception.rb b/test/ruby/test_exception.rb index 9908331689..bd4170e0fd 100644 --- a/test/ruby/test_exception.rb +++ b/test/ruby/test_exception.rb @@ -252,6 +252,27 @@ class TestException < Test::Unit::TestCase } end + def test_catch_throw_in_require_cant_be_rescued + bug18562 = '[ruby-core:107403]' + Tempfile.create(["dep", ".rb"]) {|t| + t.puts("throw :extdep, 42") + t.close + + rescue_all = Class.new(Exception) + def rescue_all.===(_) + raise "should not reach here" + end + + v = assert_throw(:extdep, bug18562) do + require t.path + rescue rescue_all => e + assert(false, "should not reach here") + end + + assert_equal(42, v, bug18562) + } + end + def test_throw_false bug12743 = '[ruby-core:77229] [Bug #12743]' Thread.start { |