diff options
author | Samuel Williams <[email protected]> | 2023-06-03 12:41:36 +0900 |
---|---|---|
committer | GitHub <[email protected]> | 2023-06-03 12:41:36 +0900 |
commit | 0402193723647b8c4f57b1453fe2192ad2788d12 (patch) | |
tree | 93f20957e7e0f3ee0f5af206fa4a481e21790539 /thread.c | |
parent | a4d92475f69f0ca3dba0f497253e600c7f90a0ad (diff) |
Fix `Thread#join(timeout)` when running inside the fiber scheduler. (#7903)
Notes
Notes:
Merged-By: ioquatix <[email protected]>
Diffstat (limited to 'thread.c')
-rw-r--r-- | thread.c | 5 |
1 files changed, 5 insertions, 0 deletions
@@ -1053,6 +1053,10 @@ thread_join_sleep(VALUE arg) if (scheduler != Qnil) { rb_fiber_scheduler_block(scheduler, target_th->self, p->timeout); + // Check if the target thread is finished after blocking: + if (thread_finished(target_th)) break; + // Otherwise, a timeout occurred: + else return Qfalse; } else if (!limit) { sleep_forever(th, SLEEP_DEADLOCKABLE | SLEEP_ALLOW_SPURIOUS | SLEEP_NO_CHECKINTS); @@ -1070,6 +1074,7 @@ thread_join_sleep(VALUE arg) RUBY_DEBUG_LOG("interrupted target_th:%u status:%s", rb_th_serial(target_th), thread_status_name(target_th, TRUE)); } + return Qtrue; } |