-
Notifications
You must be signed in to change notification settings - Fork 533
Expose async-function argument type #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
56bdc6c
Expose async-function argument type
viktorlott ba13a89
Update README.md
viktorlott c857fcb
Update alternative-setup.md
viktorlott 21446ed
Remove alternative setup documentation
viktorlott 044ebbb
Merge branch 'main' into export-types
viktorlott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Expose async-function argument type
We are exposing the async-function argument type for jsDoc type declaration support. This means that we now could do: "npm i -D @types/github-script@github:actions/github-script" and the add: "@param {import('@types/github-script').AsyncFunctionArguments} AsyncFunctionArguments". This could obviously be done in other ways too, like using "@typed-actions/github-script" instead. But it seems better to use the actual source repository instead of a third-party library to import the type declaration.
- Loading branch information
commit 56bdc6c318bf8445991a0ffe2937052a20443851
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| ## Alternative setup | ||
|
|
||
| ### Example repository structure | ||
| In this example we're using the repo structure below, but you are free | ||
| to structure it how ever you like. | ||
| ``` | ||
| root # Your repository | ||
| ├── .github | ||
| │ ├── ... | ||
| │ └── workflows | ||
| │ ├── ... | ||
| │ └── ci-workflow.yml | ||
| ├── ... | ||
| ├── actions | ||
| │ ├── action.yml (optional) | ||
| │ └── ci-test.js | ||
viktorlott marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ├── ... | ||
| └── package.json | ||
| ``` | ||
|
|
||
| ### 1. Install the github-script type | ||
| ```sh | ||
| $ npm i -D @types/github-script@github:actions/github-script | ||
| ``` | ||
|
|
||
|
|
||
| ### 2. Create `ci-test.mjs` file | ||
| ```js | ||
| // @ts-check | ||
| /** @param {import('@types/github-script').AsyncFunctionArguments} AsyncFunctionArguments */ | ||
| export default async ({ core, context }) => { | ||
| core.debug("Running something at the moment"); | ||
| return context.actor; | ||
| }; | ||
| ``` | ||
|
|
||
| ### 3. Create `ci-workflow.yml` file | ||
| ```yml | ||
| on: push | ||
|
|
||
| permissions: | ||
| pull-requests: read | ||
| contents: read | ||
|
|
||
| jobs: | ||
| example: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 | ||
|
|
||
| - run: npm ci | ||
| - uses: actions/github-script@v6 | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| result-encoding: string | ||
| script: | | ||
| const { default: script } = await import('${{ github.workspace }}/actions/ci-test.js'); | ||
viktorlott marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return await script({ github, context, core, exec, glob, io, fetch, __original_require__ }); | ||
| ``` | ||
| ## Cleaner setup (Optional) | ||
| Note that the `ci-workflow.yml` example above can be kind of tedious once you add more of them. So | ||
| to address this, one could instead use `composite` actions. | ||
| ### The `action.yml` file | ||
| ```yml | ||
| name: Typed GitHub Script | ||
| author: GitHub | ||
| description: Run simple scripts using the GitHub client | ||
| branding: | ||
| color: blue | ||
| icon: code | ||
| inputs: | ||
| script: | ||
| description: The path to script (e.g actions/ci-test.js) | ||
viktorlott marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| required: true | ||
| github-token: | ||
| description: The GitHub token used to create an authenticated client | ||
| default: ${{ github.token }} | ||
| required: false | ||
| debug: | ||
| description: Whether to tell the GitHub client to log details of its requests. true or false. Default is to run in debug mode when the GitHub Actions step debug logging is turned on. | ||
| default: ${{ runner.debug == '1' }} | ||
| user-agent: | ||
| description: An optional user-agent string | ||
| default: actions/github-script | ||
| previews: | ||
| description: A comma-separated list of API previews to accept | ||
| result-encoding: | ||
| description: Either "string" or "json" (default "json")—how the result will be encoded | ||
| default: json | ||
| retries: | ||
| description: The number of times to retry a request | ||
| default: "0" | ||
| retry-exempt-status-codes: | ||
| description: A comma separated list of status codes that will NOT be retried e.g. "400,500". No effect unless `retries` is set | ||
| default: 400,401,403,404,422 # from https://github.com/octokit/plugin-retry.js/blob/9a2443746c350b3beedec35cf26e197ea318a261/src/index.ts#L14 | ||
|
|
||
| outputs: | ||
| result: | ||
| description: The return value of the script, stringified with `JSON.stringify` | ||
| value: ${{ steps.github-script-result.outputs.result }} | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - uses: actions/github-script@v6 | ||
| id: github-script-result | ||
| with: | ||
| github-token: ${{ inputs.github-token }} | ||
| result-encoding: ${{ inputs.result-encoding }} | ||
| debug: ${{ inputs.debug }} | ||
| user-agent: ${{ inputs.user-agent }} | ||
| previews: ${{ inputs.previews }} | ||
| retries: ${{ inputs.retries }} | ||
| retry-exempt-status-codes: ${{ inputs.retry-exempt-status-codes }} | ||
| script: | | ||
| const { default: script } = await import(process.env.GITHUB_ACTION_PATH + '/${{ inputs.script }}'); | ||
| return await script({ github, context, core, exec, glob, io, fetch, __original_require__ }); | ||
| ``` | ||
| ### The `ci-workflow.yml` file | ||
| Note that we only need to specify the script here because the path will be | ||
viktorlott marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| resolved to the `uses: ./actions` path by `process.env.GITHUB_ACTION_PATH`. | ||
| i.e the same folder as we are executing the action from. | ||
| ```yml | ||
| on: push | ||
| permissions: | ||
| pull-requests: read | ||
| contents: read | ||
| jobs: | ||
| example: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 | ||
| - run: npm ci | ||
| - uses: ./actions | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| result-encoding: string | ||
| script: ci-test.js | ||
viktorlott marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ``` | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /// <reference types="node" /> | ||
| import * as core from '@actions/core'; | ||
| import * as exec from '@actions/exec'; | ||
| import { Context } from '@actions/github/lib/context'; | ||
| import { GitHub } from '@actions/github/lib/utils'; | ||
| import * as glob from '@actions/glob'; | ||
| import * as io from '@actions/io'; | ||
| import fetch from 'node-fetch'; | ||
| export declare type AsyncFunctionArguments = { | ||
| context: Context; | ||
| core: typeof core; | ||
| github: InstanceType<typeof GitHub>; | ||
| exec: typeof exec; | ||
| glob: typeof glob; | ||
| io: typeof io; | ||
| fetch: typeof fetch; | ||
| require: NodeRequire; | ||
| __original_require__: NodeRequire; | ||
| }; | ||
| export declare function callAsyncFunction<T>(args: AsyncFunctionArguments, source: string): Promise<T>; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.