Use Global.Variables instead of JobContext and include action path/ref in the message. #2214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f in the message.
88d96d5 to
4edba70
Compare
JoannaaKL
reviewed
Oct 20, 2022
JoannaaKL
reviewed
Oct 20, 2022
JoannaaKL
reviewed
Oct 20, 2022
Contributor
There was a problem hiding this comment.
Wouldn't it be a bit better performance wise if we just appended the new warnings to the old ones? This way we just have to convert to json the new ones. :)
Sorry I was not able to edit the whole block so I just appended my suggestion at the bottom. 😃
20ae8c4 to
aa36449
Compare
aa36449 to
d839310
Compare
TingluoHuang
commented
Oct 22, 2022
| { | ||
| if (!ExecutionContext.JobContext.ContainsKey("Node12ActionsWarnings")) | ||
| var repoAction = Action as RepositoryPathReference; | ||
| var warningActions = new HashSet<string>(); |
Member
Author
There was a problem hiding this comment.
using HashSet so we can remove duplication on the error message.
cory-miller
approved these changes
Nov 2, 2022
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
…f in the message. (actions#2214) * Use Global.Variables instead of JobContext and include action path/ref in the message. * encoding * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not use
JobContextfor carrying runner internal data.