Responded to feedback in PR #2313 #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jww3
commented
Dec 16, 2022
| if (_didFullyEvaluateDisplayName || !string.IsNullOrEmpty(Action.DisplayName)) | ||
| { | ||
| return false; | ||
| return true; |
Contributor
Author
There was a problem hiding this comment.
This is a subtle change in behavior, but fortunately there weren't many existing callers (mainly just unit tests) and even fewer existing callers that even bothered checking the return value.
jww3
commented
Dec 16, 2022
| { | ||
| if (updated) | ||
| { | ||
| actionRunner.ExecutionContext.UpdateTimelineRecordDisplayName(actionRunner.DisplayName); |
Contributor
Author
There was a problem hiding this comment.
when updated is true, actionRunner.DisplayName is effectively guaranteed to be non-null.
jww3
commented
Dec 16, 2022
| } | ||
| catch (Exception ex) | ||
| { | ||
| Trace.Warning("Caught exception while attempting to evaulate/update the step's DisplayName. Exception Details: {0}", ex); |
Contributor
Author
There was a problem hiding this comment.
now a warning since I can't assume anything about the caller of this new method.
jww3
commented
Dec 16, 2022
Comment on lines
+203
to
+204
| DisplayName = explicitDisplayName, | ||
| DisplayNameToken = new BasicExpressionToken(null, null, null, "matrix.node"), |
Contributor
Author
There was a problem hiding this comment.
in this unit test, we're setting both DisplayName and DisplayNameToken.
AvaStancu
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2313
Note above: if approved, I'll merge this branch into the branch that backs #2313 (users/jww3/jit-displayname-evaluation). That PR already has a detailed description.
Before
After