Show more information in the runner log #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Runner.Worker/JobExtension.cs
Outdated
| context.Output($"Uses: {workflowFileFullPath.Value}"); | ||
| var usesOutput = $"Uses: {workflowFileFullPath.Value}"; | ||
| if (message.Variables.TryGetValue("system.workflowFileRef", out VariableValue workflowFileRef) | ||
| && message.Variables.TryGetValue("system.workflowFileSha", out VariableValue workflowFileSha)) |
Member
There was a problem hiding this comment.
Suggested change
| && message.Variables.TryGetValue("system.workflowFileSha", out VariableValue workflowFileSha)) | |
| || message.Variables.TryGetValue("system.workflowFileSha", out VariableValue workflowFileSha)) |
should it be OR?
Contributor
Author
There was a problem hiding this comment.
oh yea you are right :-)
Just to note, we are sending both values but in case the user is using reusable workflow using sha then workflowFileRef will be empty. Still that will return true for this TryGetValue, so it should not matter much.
TingluoHuang
previously approved these changes
Jan 18, 2023
TingluoHuang
approved these changes
Jan 18, 2023
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
* fix typo * add workflow ref in the log * show job name for all jobs * update ref * reflect the feedback * fix a small bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide more information in the run log, add
Actions service side PR: https://github.com/github/actions-dotnet/pull/14151
Related to https://github.com/github/actions-enablers-policy/issues/704