Adding Consistency to 'Failed To Resolve Action Download Info' Infrastructure Error Flagging #2488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
reviewed
Mar 17, 2023
thboop
reviewed
Mar 17, 2023
thboop
reviewed
Mar 28, 2023
thboop
reviewed
Mar 28, 2023
jww3
reviewed
Mar 28, 2023
jww3
reviewed
Mar 28, 2023
jww3
reviewed
Mar 28, 2023
jww3
reviewed
Mar 28, 2023
Co-authored-by: Tingluo Huang <[email protected]>
Co-authored-by: Tingluo Huang <[email protected]>
Co-authored-by: Tingluo Huang <[email protected]>
Co-authored-by: Tingluo Huang <[email protected]>
Co-authored-by: Tingluo Huang <[email protected]>
TingluoHuang
reviewed
Apr 4, 2023
src/Runner.Worker/ActionRunner.cs
Outdated
| } | ||
| catch (WebApi.FailedToResolveActionDownloadInfoException ex) | ||
| { | ||
| throw new WebApi.FailedToResolveActionDownloadInfoException("Failed to resolve action download info", ex); |
Member
There was a problem hiding this comment.
why do we need to catch the exception and rethrow the same exception with a different message?
TingluoHuang
reviewed
Apr 4, 2023
TingluoHuang
reviewed
Apr 4, 2023
TingluoHuang
reviewed
Apr 4, 2023
Co-authored-by: Tingluo Huang <[email protected]>
TingluoHuang
approved these changes
May 11, 2023
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
…tructure Error Flagging (actions#2488) * adding extra catch for download failure in composite actions * Adding infra error * Adding error handling centralizing * updating try catch bubbling * cleaning up commits * cleaning up commits * cleaning up commits * updating bubbler * cleaning up test files * Fixing linting errors * updating exception bubble * reverting composite * updating catch to not exclude other exceptions * removing uneeded import * Update src/Runner.Worker/ActionRunner.cs Co-authored-by: Tingluo Huang <[email protected]> * Update src/Runner.Worker/ActionManager.cs Co-authored-by: Tingluo Huang <[email protected]> * Update src/Runner.Worker/ActionManager.cs Co-authored-by: Tingluo Huang <[email protected]> * Update src/Runner.Worker/ActionManager.cs Co-authored-by: Tingluo Huang <[email protected]> * Update src/Runner.Worker/ActionManager.cs Co-authored-by: Tingluo Huang <[email protected]> * moving download out of for loop; reverting exception wrap * Update src/Runner.Worker/ActionManager.cs Co-authored-by: Tingluo Huang <[email protected]> * Adding blank lines back * Adding blank lines back * removing uneeded catch for download fail * adding var back for consistency * formatting clean --------- Co-authored-by: Tingluo Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://github.com/github/c2c-actions-runtime/issues/2182:
When an action fails to download, it does not get consistently flagged in Kusto as an infrastructure error. After manually throwing an error in the download function (
GetDownloadInfoAsync), we should bubble up the error so that it can be caught by the original caller.To replicate locally:
throw new WebApi.FailedToResolveActionDownloadInfoException(...)hereExample Repo with error flagging:
https://github.com/vmjoseph/CompositeActionsTest/actions/runs/4546302712/jobs/8014764926