Skip to content

Adding curl --retry-all-errors for external tool downloads #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TingluoHuang merged 3 commits into from
Apr 20, 2023
Merged

Adding curl --retry-all-errors for external tool downloads #2557

TingluoHuang merged 3 commits into from
Apr 20, 2023

Conversation

@mspletz
Copy link
Contributor

@mspletz mspletz commented Apr 20, 2023 •
edited
Loading

This is a follow up PR to #2552 to force retrying curl for external tool downloads.

This checks if the curl version is > 7.71.0 (when --retry-all-errors was introduced) and uses that flag if the curl version is recent enough.

@mspletz mspletz requested a review from a team as a code owner April 20, 2023 20:53
@TingluoHuang TingluoHuang enabled auto-merge (squash) April 20, 2023 20:59
@TingluoHuang TingluoHuang merged commit af6ed41 into actions:main Apr 20, 2023
nikola-jokic pushed a commit to nikola-jokic/runner that referenced this pull request May 12, 2023
@mspletz @nikola-jokic
Adding curl --retry-all-errors for external tool downloads (actions#2557
601990b 
)

* adding retry-all-errors based on curl version >= 7.71.0

* adding logging

* fixing conditional logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TingluoHuang TingluoHuang TingluoHuang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mspletz @TingluoHuang