Skip to content

Fix telemetry publish from JobServerQueue. #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TingluoHuang merged 1 commit into from
Oct 10, 2023
Merged

Fix telemetry publish from JobServerQueue. #2919

TingluoHuang merged 1 commit into from
Oct 10, 2023

Conversation

@TingluoHuang
Copy link
Member

@TingluoHuang TingluoHuang commented Oct 10, 2023

_jobServerQueue get set to NULL during ShutdownQueue() which cause we don't get any telemetry uploaded.

@TingluoHuang TingluoHuang requested a review from a team as a code owner October 10, 2023 17:53
@TingluoHuang TingluoHuang merged commit 4647f3e into main Oct 10, 2023
@TingluoHuang TingluoHuang deleted the users/tihuang/fixtelemetry branch October 10, 2023 18:24
TingluoHuang added a commit that referenced this pull request Oct 10, 2023
@TingluoHuang
Fix telemetry publish from JobServerQueue. (#2919)
f26eb98
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsciple ericsciple ericsciple approved these changes

+1 more reviewer

@pje pje pje approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TingluoHuang @pje @ericsciple