Write archive hash/size to log after extraction error #2923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What would help with figuring out if something's gone really wrong on the codeload side would be to store the error message from tar somewhere. |
c48f404 to
1823d84
Compare
1823d84 to
236e9e7
Compare
Contributor
|
@larsxschneider Regarding testing, would extracting the new logic into a separate function that for ex. receives the |
Member
|
@larsxschneider I will take over the PR with more changes (ex: send the output from |
Member
|
Taking over with #2939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to understand the corrupt archives better. Let's log their size. Maybe this gives us a new clue in what way these archives are corrupted.