Upgrade node.js to latest version. #3935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Node.js version used in the alpine build and refines a regex in the file-hashing utility to avoid matching double commas.
- Refine regex in
expandto use a negative lookahead, preventing matches on,, - Bump
NODE20_VERSIONfrom20.19.1to20.19.3
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Misc/layoutbin/hashFiles/index.js | Updated regex from /,.*\}/ to /,(?!,).*\}/ to exclude ,, |
| src/Misc/externals.sh | Bumped NODE20_VERSION to 20.19.3 for Node.js upgrade |
Files not reviewed (1)
- src/Misc/expressionFunc/hashFiles/package-lock.json: Language not supported
TingluoHuang
commented
Jul 7, 2025
| if (!isSequence && !isOptions) { | ||
| // {a},b} | ||
| if (m.post.match(/,.*\}/)) { | ||
| if (m.post.match(/,(?!,).*\}/)) { |
Member
Author
There was a problem hiding this comment.
this is changed by compiling the source file
TingluoHuang
commented
Jul 7, 2025
| } | ||
| }, | ||
| "node_modules/brace-expansion": { | ||
| "version": "1.1.11", |
Member
Author
There was a problem hiding this comment.
this is changed by running npm audit fix
ericsciple
approved these changes
Jul 7, 2025
This was referenced Jul 8, 2025
LouisHaftmann
pushed a commit
to falcondev-oss/github-actions-runner
that referenced
this pull request
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/github/c2c-actions-support/issues/5278