Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't need these methods
  • Loading branch information
salmanmkc committed Aug 7, 2025
commit cbfebb56ac8852e5dc1feccf2b95eba698fa00a6
15 changes: 0 additions & 15 deletions src/Runner.Worker/FeatureManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,5 @@ public static bool IsContainerHooksEnabled(Variables variables)
var isContainerHooksPathSet = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable(Constants.Hooks.ContainerHooksPath));
return isContainerHookFeatureFlagSet && isContainerHooksPathSet;
}

public static bool IsFeatureEnabled(Variables variables, string featureFlag)
{
return variables?.GetBoolean(featureFlag) ?? false;
}

public static bool IsUseNode24ByDefaultEnabled(Variables variables)
{
return IsFeatureEnabled(variables, Constants.Runner.NodeMigration.UseNode24ByDefaultFlag);
}

public static bool IsRequireNode24Enabled(Variables variables)
{
return IsFeatureEnabled(variables, Constants.Runner.NodeMigration.RequireNode24Flag);
}
}
}
4 changes: 2 additions & 2 deletions src/Runner.Worker/Handlers/HandlerFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ public IHandler Create(
// We don't modify if node24 was explicitly specified
if (string.Equals(nodeData.NodeVersion, Constants.Runner.NodeMigration.Node20, StringComparison.InvariantCultureIgnoreCase))
{
bool useNode24ByDefault = FeatureManager.IsUseNode24ByDefaultEnabled(executionContext.Global.Variables);
bool requireNode24 = FeatureManager.IsRequireNode24Enabled(executionContext.Global.Variables);
bool useNode24ByDefault = executionContext.Global.Variables?.GetBoolean(Constants.Runner.NodeMigration.UseNode24ByDefaultFlag) ?? false;
bool requireNode24 = executionContext.Global.Variables?.GetBoolean(Constants.Runner.NodeMigration.RequireNode24Flag) ?? false;

var (nodeVersion, configWarningMessage) = NodeUtil.DetermineActionsNodeVersion(environment, useNode24ByDefault, requireNode24);
var (finalNodeVersion, platformWarningMessage) = NodeUtil.CheckNodeVersionForLinuxArm32(nodeVersion);
Expand Down
Loading