Skip to content

Implementation of python's caching #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaksimZhukov merged 13 commits into from
Nov 17, 2021
Merged

Implementation of python's caching #266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
952fef3
add support for caching
dmitry-shibanov Oct 27, 2021
c98dcde
resolving comments
dmitry-shibanov Nov 3, 2021
b321c7b
add unit and e2e tests
dmitry-shibanov Nov 9, 2021
0860a2d
work on fixing errors
dmitry-shibanov Nov 9, 2021
3a7c99c
try to use pipx and inline pip tools installation
dmitry-shibanov Nov 9, 2021
73eda7c
remove pypy-2.7 from e2e-cache
dmitry-shibanov Nov 9, 2021
87683fb
add documentation
dmitry-shibanov Nov 10, 2021
f3bb768
remove async from getCacheDistributor
dmitry-shibanov Nov 10, 2021
07c09af
fix cache restore tests
dmitry-shibanov Nov 10, 2021
1918fc7
resolving comments
dmitry-shibanov Nov 15, 2021
f823876
fixing docs
dmitry-shibanov Nov 15, 2021
aaeea74
resolve comments and add licenses
dmitry-shibanov Nov 16, 2021
204896d
format code
dmitry-shibanov Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
format code
  • Loading branch information
@dmitry-shibanov
dmitry-shibanov committed Nov 16, 2021
commit 204896dae5d30ec5ac5638f7dd029c066f592b11
2 changes: 1 addition & 1 deletion dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7154,7 +7154,7 @@ class PipenvCache extends cache_distributor_1.default {
getCacheGlobalDirectories() {
return __awaiter(this, void 0, void 0, function* () {
let virtualEnvRelativePath;
// Default virtualenv directories are hardcoded,
// Default virtualenv directories are hardcoded,
// because pipenv is not preinstalled on hosted images and virtualenv is not created:
// https://github.com/pypa/pipenv/blob/1daaa0de9a0b00d386c6baeb809d8d4ee6795cfd/pipenv/utils.py#L1990-L2002
if (process.platform === 'win32') {
Expand Down
2 changes: 1 addition & 1 deletion src/cache-distributions/pipenv-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class PipenvCache extends CacheDistributor {
protected async getCacheGlobalDirectories() {
let virtualEnvRelativePath;

// Default virtualenv directories are hardcoded,
// Default virtualenv directories are hardcoded,
// because pipenv is not preinstalled on hosted images and virtualenv is not created:
// https://github.com/pypa/pipenv/blob/1daaa0de9a0b00d386c6baeb809d8d4ee6795cfd/pipenv/utils.py#L1990-L2002
if (process.platform === 'win32') {
Expand Down