Remove unnecessary .compact call#562
Merged
tagliala merged 1 commit intoactiveadmin:masterfrom Dec 16, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 17 17
Lines 460 460
=======================================
Hits 434 434
Misses 26 26 ☔ View full report in Codecov by Sentry. |
javierjulio
approved these changes
Dec 15, 2023
Member
javierjulio
left a comment
There was a problem hiding this comment.
Thanks! I'm not sure why I left that in.
The `.compact` method is used to remove nil elements from an array. However, in this context, it is unnecessary because the `.map` operation is already creating an array of strings, and there's no `nil` values that could be removed
20c8ffb to
4835955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.compactmethod is used to remove nil elements from an array. However, in this context, it is unnecessary because the.mapoperation is already creating an array of strings, and there's nonilvalues that could be removed