Skip to content

Conversation

@Samoed
Copy link
Contributor

@Samoed Samoed commented Aug 11, 2025

Description

Add example defining custom prometheus metrics to documentation

Fixes #2348

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Samoed Samoed requested a review from draincoder as a code owner August 11, 2025 12:13
@github-actions github-actions bot added documentation Improvements or additions to documentation Observability labels Aug 11, 2025
@CLAassistant
Copy link

CLAassistant commented Aug 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@draincoder draincoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add example for inc custom counter

@Samoed Samoed requested a review from draincoder August 11, 2025 12:30
draincoder
draincoder previously approved these changes Aug 11, 2025
@draincoder draincoder assigned draincoder and unassigned draincoder Aug 11, 2025
@draincoder draincoder enabled auto-merge August 11, 2025 13:54
@draincoder draincoder added this pull request to the merge queue Aug 11, 2025
Merged via the queue into ag2ai:main with commit 63e7e30 Aug 11, 2025
27 checks passed
@draincoder
Copy link
Collaborator

@Samoed Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Observability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Documnetation example on how to add custom Prometheus metric

4 participants