fix resume_threads() #1040
Merged
fix resume_threads() #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanallen
reviewed
Nov 13, 2025
| if (sleepq.empty() && !if_update_now()) { | ||
| return count; | ||
| } | ||
| do { |
Contributor
There was a problem hiding this comment.
Maybe sleepq.empty() is true here, then sleepq.front() will crash.
Collaborator
Author
There was a problem hiding this comment.
I should move if_update_now() out of the if.
71ab8e4 to
7df6195
Compare
ivanallen
approved these changes
Nov 14, 2025
beef9999
approved these changes
Nov 14, 2025
photonlibos
pushed a commit
that referenced
this pull request
Nov 16, 2025
lihuiba
added a commit
that referenced
this pull request
Nov 16, 2025
lihuiba
added a commit
that referenced
this pull request
Nov 16, 2025
Co-authored-by: Huiba Li <[email protected]>
photonlibos
added a commit
that referenced
this pull request
Nov 16, 2025
Co-authored-by: Huiba Li <[email protected]>
lihuiba
added a commit
that referenced
this pull request
Nov 16, 2025
Co-authored-by: Huiba Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.