Fix PHOTON_BUILD_WITH_ASAN #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
approved these changes
Aug 12, 2025
photonlibos
pushed a commit
that referenced
this pull request
Aug 12, 2025
lihuiba
pushed a commit
that referenced
this pull request
Aug 12, 2025
Co-authored-by: Coldwings <[email protected]>
photonlibos
added a commit
that referenced
this pull request
Aug 12, 2025
Co-authored-by: Coldwings <[email protected]>
lihuiba
pushed a commit
that referenced
this pull request
Aug 12, 2025
Co-authored-by: Coldwings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compile option
PHOTON_BUILD_WITH_ASANlinks address sanitizer but never compiled with it.That makes it totally waisted.
Modify the CMakeLists to add
-fsanitizer=addressin compiling, and move code blocks associated by asan stack address hooks to the place after struct thread since it needs to use the struct definition.