Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Fixed issues with timezone and locale incorrectly set in DateTest, DateTest_tz, Issue1298, Issue1679, and Issue1977#2172

Merged
wenshao merged 1 commit intoalibaba:masterfrom
OrDTesters:LocaleAndTimezoneInTestsFix
Dec 12, 2018
Merged

Fixed issues with timezone and locale incorrectly set in DateTest, DateTest_tz, Issue1298, Issue1679, and Issue1977#2172
wenshao merged 1 commit intoalibaba:masterfrom
OrDTesters:LocaleAndTimezoneInTestsFix

Conversation

@OrDTesters
Copy link
Contributor

Similar to the following, recently accepted pull request, #2148 the tests in DateTest, DateTest_tz, Issue1298, Issue1679, and Issue1977 also depends on the time zone and the locale. To the best of my knowledge, these are the remaining classes in the project with this issue.

The tests in these classes can be fixed by running a setup to change the time and locale to "Asia/Shanghai" and "China" (respectively). This setup is the same as the one in other classes such as the DateTest class. This fix will enable the tests in these classes to now pass in any test run order and by itself. Let me know if you want to discuss more.

…st, DateTest_tz, Issue1298, Issue1679, and Issue1977
@codecov-io
Copy link

Codecov Report

Merging #2172 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2172      +/-   ##
============================================
- Coverage     81.85%   81.84%   -0.01%     
+ Complexity     6856     6852       -4     
============================================
  Files           140      140              
  Lines         25492    25492              
  Branches       6088     6088              
============================================
- Hits          20867    20865       -2     
  Misses         2906     2906              
- Partials       1719     1721       +2
Impacted Files Coverage Δ Complexity Δ
...java/com/alibaba/fastjson/parser/ParserConfig.java 82.56% <0%> (-0.19%) 186% <0%> (-1%)
...n/java/com/alibaba/fastjson/util/JavaBeanInfo.java 87.5% <0%> (-0.19%) 194% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3e2af...b1f4984. Read the comment docs.

@wenshao wenshao merged commit fb5967d into alibaba:master Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants