This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Fixed issues with timezone and locale incorrectly set in DateTest, DateTest_tz, Issue1298, Issue1679, and Issue1977#2172
Merged
wenshao merged 1 commit intoalibaba:masterfrom Dec 12, 2018
Conversation
…st, DateTest_tz, Issue1298, Issue1679, and Issue1977
Codecov Report
@@ Coverage Diff @@
## master #2172 +/- ##
============================================
- Coverage 81.85% 81.84% -0.01%
+ Complexity 6856 6852 -4
============================================
Files 140 140
Lines 25492 25492
Branches 6088 6088
============================================
- Hits 20867 20865 -2
Misses 2906 2906
- Partials 1719 1721 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the following, recently accepted pull request, #2148 the tests in DateTest, DateTest_tz, Issue1298, Issue1679, and Issue1977 also depends on the time zone and the locale. To the best of my knowledge, these are the remaining classes in the project with this issue.
The tests in these classes can be fixed by running a setup to change the time and locale to "Asia/Shanghai" and "China" (respectively). This setup is the same as the one in other classes such as the DateTest class. This fix will enable the tests in these classes to now pass in any test run order and by itself. Let me know if you want to discuss more.