Skip to content

Conversation

@Clarence-pan
Copy link
Contributor

The "--output-path" option of "rax-scripts" was not working. I've found the reason, and figured out a
simple solution.


Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以这么做的原因是 cli 里面把参数映射到 env 里了, 这种有副作用的映射可能会导致一些不可预知的问题, 不过这是另一个话题了.

I would approve this change.

@yuanyan yuanyan merged commit 914558c into alibaba:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants