Skip to content

fix: path error in windows #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjun1011 merged 1 commit into from
May 10, 2019
Merged

fix: path error in windows #1059

chenjun1011 merged 1 commit into from
May 10, 2019

Conversation

@chenjun1011
Copy link
Collaborator

@chenjun1011 chenjun1011 commented May 10, 2019

No description provided.

@chenjun1011 chenjun1011 requested a review from wssgcg1213 May 10, 2019 03:31
wssgcg1213
wssgcg1213 approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: https://nodejs.org/docs/latest-v8.x/api/process.html#process_process_platform

process.platform looks good to me :);

@chenjun1011 chenjun1011 merged commit ff6feca into master May 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-miniapp-plugin branch May 10, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenjun1011 @wssgcg1213