Skip to content

fix: react compatibility#1116

Merged
yuanyan merged 2 commits intoalibaba:masterfrom
94cstyles:fix-react-compatibility
Jun 26, 2019
Merged

fix: react compatibility#1116
yuanyan merged 2 commits intoalibaba:masterfrom
94cstyles:fix-react-compatibility

Conversation

@94cstyles
Copy link
Contributor

默认导出default,不然会出现下面情况。

import React, { useState } from 'react'

console.log(useState); // function
console.log(React); // undefined

driver-dom 引用有问题

import DriverDOM from 'driver-dom';
// to
import * as DriverDOM from 'driver-dom';

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2019

CLA assistant check
All committers have signed the CLA.

@94cstyles 94cstyles force-pushed the fix-react-compatibility branch from 1f04c4b to c8ab605 Compare June 26, 2019 05:15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑 raxDomRender -> domRender

Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanyan yuanyan merged commit f4008dd into alibaba:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments