Skip to content

Feat: update App Shell plugin #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Orange-C merged 1 commit into from
Aug 6, 2019
Merged

Feat: update App Shell plugin #1206

Orange-C merged 1 commit into from
Aug 6, 2019

Conversation

@fyangstudio
Copy link
Collaborator

@fyangstudio fyangstudio commented Aug 6, 2019

Update PWAAppShellPlugin.js. Use webpack instead of babel transform. Supports import method and @core/xxx modules

Orange-C
Orange-C approved these changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@Orange-C Orange-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@Orange-C Orange-C merged commit 7f7e9cb into feat-rax-engineering Aug 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-rax-pwa-appshell branch August 6, 2019 06:19
@weekly-digest weekly-digest bot mentioned this pull request Aug 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjun1011 chenjun1011 Awaiting requested review from chenjun1011

@snoozybot snoozybot Awaiting requested review from snoozybot

1 more reviewer

@Orange-C Orange-C Orange-C approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fyangstudio @Orange-C