feat(miniapp): support using miniapp plugins#1944
Merged
ChrisCindy merged 19 commits intobeta/miniapp-0716from Jul 29, 2020
Merged
feat(miniapp): support using miniapp plugins#1944ChrisCindy merged 19 commits intobeta/miniapp-0716from
ChrisCindy merged 19 commits intobeta/miniapp-0716from
Conversation
SoloJiang
reviewed
Jul 22, 2020
| methods: createEventProxy() | ||
| methods: createEventProxy(), | ||
| onInit() { | ||
| cache.setElementInstance(this); |
| }); | ||
| nativeInfo.events.forEach(event => { | ||
| const eventName = `${this.$_behavior}_${event}_${__methodCount++}`; | ||
| domInfo[event] = eventName; |
Collaborator
There was a problem hiding this comment.
__methodCount 用 utils/tool 的 getId 替换一下吧，另外加点注释吧
chenjun1011
approved these changes
Jul 28, 2020
SoloJiang
approved these changes
Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.